[Bug-openmcl] two one-liners for loop

bryan o'connor bryan-openmcl at lunch.org
Mon Jan 19 10:15:55 MST 2004


> In case anyone's counting, the current failure total's down to ~75
> (depending on what you mean by "current".)
[...]
> I think that when Bryan started this a few weeks back he said that the
> number of failures was > 700, so this is definite improvement ...

pfdietz did some major updates this past week, so we crept
up a bit to ~90.  still, i agree it's a major improvement.
when i first started, the tests wouldn't even run.

> - a few LOOP failures

i killed off the remaining loop failures.  like the last one,
it's a ~6 character fix that took seconds to diagnose but way
too long to find.

the loop macro breaks the loop into 5 sections (prologue,
before-loop, main-body, after-loop, epilogue).  the bug
caused certain end-tests to be put into before-loop instead
of the main-body.

like the last one, this fix is identical to sbcl's fix.

-------------- next part --------------
Index: loop.lisp
===================================================================
RCS file: /usr/local/tmpcvs/ccl-0.14-dev/ccl/library/loop.lisp,v
retrieving revision 1.2
diff -c -1 -r1.2 loop.lisp
*** loop.lisp	18 Jan 2004 04:00:30 -0000	1.2
--- loop.lisp	19 Jan 2004 16:57:45 -0000
***************
*** 1360,1362 ****
  (defun loop-do-return ()
!   (loop-pseudo-body (loop-construct-return (loop-get-form))))
  
--- 1360,1362 ----
  (defun loop-do-return ()
!   (loop-emit-body (loop-construct-return (loop-get-form))))
  
-------------- next part --------------



More information about the Bug-openmcl mailing list